@sgiehl opened this Pull Request on November 24th 2020 Member


Page will be frozen at the current scroll position and only the dialog will scroll (if too high for window)

Currently only tested in Chrome & Firefox on Windows. We need to do some more cross browser testing before merging.

fixes #14968


  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on December 11th 2020 Member

cross browser testing via browserstack/locally:

  • on windows, IE 11, scrolling in the dialog works, but outside the modal doesn't seem to scroll (not sure if it's related to this or just broken)
  • works in windows, edge
  • works in mac/chrome
  • works in mac/firefox
  • works in mac/safari
  • works in ios/safari
  • doesn't quite work in android/chrome, when I open the dialog it scrolls to near the top for some reason (the original scroll position changes)
@diosmosis commented on December 11th 2020 Member

code looks good 👍, there are some screenshot test failures

@sgiehl commented on December 14th 2020 Member

I've changed that to use $(window).scrollTop() instead of window.scrollY, which should fix the behavior for IE11

This Pull Request was closed on December 15th 2020
Powered by GitHub Issue Mirror