Adds missing field for Campaign ID to campaign builder #16782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
diosmosis
reviewed
Dec 11, 2020
plugins/Referrers/lang/en.json
Outdated
| @@ -18,6 +18,8 @@ | |||
| "CampaignGroupHelp": "This parameter is used to track a Campaign Group to identify a group or audience. Campaign groups are helpful for tracking the overall performance of multiple campaigns with similar goals.", | |||
| "CampaignPlacement": "Campaign Placement", | |||
| "CampaignPlacementHelp": "Used to describe the advertising placement or position, for example an entire website, specific pages from a website, an individual ad unit positioned on a single page, a video, a mobile phone app, and more.", | |||
| "CampaignId": "Campaign ID", | |||
| "CampaignIdHelp": "This parameter is used to track a Campaign ID: an identifier which can be a number or any string of data up to 100 characters.", | |||
There was a problem hiding this comment.
I think this might sound better as: "a Campaign ID: a unique identifier for the command consisting of at most 100 numbers, letters or symbols.", what do you think?
There was a problem hiding this comment.
@tsteur that was the text we are using here as well: https://matomo.org/docs/tracking-campaigns-url-builder/
Maybe we should update that one then, too?
There was a problem hiding this comment.
updated it, page might be cached though for a bit
|
tested locally, everything works. thought there would be a test failure in CampaignBuilder_spec.js, but not seeing one. |
|
@diosmosis the fields only appear when MarketingCampaign plugin is installed, that's why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes #16233
Review