@sgiehl opened this Pull Request on November 24th 2020 Member

Description:

  • Introduced a new method getUsageWarning that allows triggering custom diagnostic warnings when a location provider is being used. (Currently used for Default and GeoIP2 Server provider)
  • Diagnostic now check these states:
    • configured provider is not available -> Error
    • configured provider is not working -> Error (with provider error message if available)
    • configured provider is working but has usage warning -> Warning (with provider usage warning)
    • configured provider is working (no usage warning) -> OK

In addition the errors will now also be shown in geolocation admin is notification.

fixes #16427

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on December 14th 2020 Member

@diosmosis switchich to the server module should show this in the system check:

image

This Pull Request was closed on December 14th 2020
Powered by GitHub Issue Mirror