Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves Geolocation diagnostics #16780

Merged
merged 3 commits into from Dec 14, 2020
Merged

Improves Geolocation diagnostics #16780

merged 3 commits into from Dec 14, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 24, 2020

Description:

  • Introduced a new method getUsageWarning that allows triggering custom diagnostic warnings when a location provider is being used. (Currently used for Default and GeoIP2 Server provider)
  • Diagnostic now check these states:
    • configured provider is not available -> Error
    • configured provider is not working -> Error (with provider error message if available)
    • configured provider is working but has usage warning -> Warning (with provider usage warning)
    • configured provider is working (no usage warning) -> OK

In addition the errors will now also be shown in geolocation admin is notification.

fixes #16427

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 24, 2020
@sgiehl sgiehl added this to the 4.1.0 milestone Nov 24, 2020
diosmosis
diosmosis approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works locally. Only thing I noticed is that the server module warning you mentioned in the original ticket is not here. Does this still need to be added?

@sgiehl
Copy link
Member Author

sgiehl commented Dec 14, 2020

@diosmosis switchich to the server module should show this in the system check:

image

@diosmosis diosmosis merged commit a3701ab into 4.x-dev Dec 14, 2020
@diosmosis diosmosis deleted the geolocdiagnostics branch December 14, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Replace confusing GeoIP warnings
2 participants
@sgiehl @diosmosis