@sgiehl opened this Pull Request on November 24th 2020 Member

Description:

fixes #16778

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on November 24th 2020 Member

@sgiehl is there any test that should have found this error?

@sgiehl commented on November 25th 2020 Member

@tsteur the seo widget was actually excluded from UI tests. Guess that was due to the external requests with changing results. I've now added a UI test with fake responses for the requested providers. So hopefully we should see it the next time the widget breaks.

Btw. I've also updated the Alexa metric provider. It requested eg https://data.alexa.com/data?cli=10&url=matomo.org to fetch some metrics. But at least for me that URL now always returns Okay, so guess it's no longer available. (ping @Findus23)

This Pull Request was closed on November 25th 2020
Powered by GitHub Issue Mirror