Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seo widget #16779

Merged
merged 3 commits into from Nov 25, 2020
Merged

Fix seo widget #16779

merged 3 commits into from Nov 25, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 24, 2020

Description:

fixes #16778

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 24, 2020
@sgiehl sgiehl added this to the 4.0.1 milestone Nov 24, 2020
@tsteur
Copy link
Member

tsteur commented Nov 24, 2020

@sgiehl is there any test that should have found this error?

@sgiehl
Copy link
Member Author

sgiehl commented Nov 25, 2020

@tsteur the seo widget was actually excluded from UI tests. Guess that was due to the external requests with changing results. I've now added a UI test with fake responses for the requested providers. So hopefully we should see it the next time the widget breaks.

Btw. I've also updated the Alexa metric provider. It requested eg https://data.alexa.com/data?cli=10&url=matomo.org to fetch some metrics. But at least for me that URL now always returns Okay, so guess it's no longer available. (ping @Findus23)

@tsteur tsteur merged commit 4695315 into 4.x-dev Nov 25, 2020
@tsteur tsteur deleted the fixseowidget branch November 25, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.

SEO Plugin broken
2 participants
@sgiehl @tsteur