The missing condition was the only difference in the code I could see.
@diosmosis two Integration tests are failing. Guess it's unrelated to this PR. But would be good to fix them....
@diosmosis what happens if there is an
archive_invalidation entry for this segment that is for
today. Then it sends the request to archive. It thinks the segment was archived (but in reality it was skipped), and then it removes the archive_invalidation entry.
Would the segment still be archived the next day after midnight? Or maybe because there's no archive_invalidation entry it wold not be archived in that case? Could you double check this maybe?
@tsteur I see, will add the check to QueueConsumer as well and test both cases.
@diosmosis let me know when it's pushed and we'll include it in 4.0.2.
Tested it quite a few times and worked for me 👍 left one comment regarding a comment in the code. otherwise feel free to merge @diosmosis 🚀