Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When accessing UI with unsupported browser throw error and suggest to use other browser #16776

Closed
tsteur opened this issue Nov 23, 2020 · 2 comments · Fixed by #17258
Closed

When accessing UI with unsupported browser throw error and suggest to use other browser #16776

tsteur opened this issue Nov 23, 2020 · 2 comments · Fixed by #17258
Assignees
@flamisz
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Milestone
4.4.0

Comments

@tsteur
Copy link
Member

tsteur commented Nov 23, 2020 •
edited

When IE 10 is used, we may want to show an exception that it is not supported instead of seeing a broken screen. This can also have security benefits since some features like noreferrer might not work in IE10.
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Nov 23, 2020
@tsteur tsteur added this to the 4.2.0 milestone Nov 23, 2020
@flamisz
Copy link
Contributor

flamisz commented Feb 24, 2021

@tsteur when you say exception you mean really exception, like we do with other exceptions? So matomo actually can't be loaded with not supported browsers this way? That's what we want to achieve here?

Because this can be done in the FrontController so it will happen everywhere this way (even with the widgets).

Or we want to show an notification or warning only but let the page loaded and used by the user with not supported browsers?

Thanks

@tsteur
Copy link
Member Author

tsteur commented Feb 24, 2021

An exception be fine. We wouldn't want users to be able to use it maybe since it might not be secure.

@flamisz flamisz mentioned this issue Feb 24, 2021
Merged
9 tasks
@flamisz flamisz self-assigned this Feb 24, 2021
@mattab mattab modified the milestones: 4.5.0, 4.4.0 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flamisz flamisz

Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement.
Projects
None yet
Milestone
4.4.0
Development

Successfully merging a pull request may close this issue.

not supported browser exception matomo-org/matomo
3 participants
@tsteur @mattab @flamisz