Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--skip-segments-today no longer working in Matomo 4? #16775

Closed
tsteur opened this issue Nov 23, 2020 · 0 comments · Fixed by #16777
Closed

--skip-segments-today no longer working in Matomo 4? #16775

tsteur opened this issue Nov 23, 2020 · 0 comments · Fixed by #16777
Assignees
@diosmosis
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.0.x

Comments

@tsteur
Copy link
Member

tsteur commented Nov 23, 2020

If I see in the code correctly this flag doesn't do anything anymore? Can you check @diosmosis ?

It should basically skip archiving a segment in today's timezone (I think unless it was created or changed recently see https://github.com/matomo-org/matomo/blob/3.14.1/core/CronArchive.php#L2000 ) see https://github.com/matomo-org/matomo/blob/3.14.1/plugins/CoreConsole/Commands/CoreArchiver.php#L105-L106
@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Nov 23, 2020
@tsteur tsteur added this to the 4.0.1 milestone Nov 23, 2020
@diosmosis diosmosis self-assigned this Nov 23, 2020
@diosmosis diosmosis mentioned this issue Nov 24, 2020
Merged
9 tasks
@tsteur tsteur modified the milestones: 4.0.1, 4.0.2, 4.0.3 Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.x
Development

Successfully merging a pull request may close this issue.

re-add missing condition for --skip-segments-today matomo-org/matomo
2 participants
@diosmosis @tsteur