Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable features that are inaccurate if visit data is not profilable #16773

Open
wants to merge 120 commits into
base: 4.x-dev
Choose a base branch
from

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Nov 23, 2020

Description:

Introduces a new core metric, nb_profilable calculated with VisitsSummary metrics as the sum of visits that are profilable. If less than 1% of visits for a period are not profilable features that depend on profilable data are hidden or disabled. This includes:

  • reports that rely on detecting returning visitors (everywhere in the UI)
  • the nb_uniq_visitors metric (in the UI and API)
  • segments for dimensions that rely on detecting returning visitors (hidden in the UI only)
  • visitor log features that rely on detecting returning visitors

Other changes:

  • nb_profilable is stored even if it's value is 0, this is to be able to differentiate between archives that are old and do not have the metric vs ones that are new and have 0 profilable visits. There is an alternative to check whether ts_archived is < a certain time, but getting this information w/ numeric data is a bit complicated. It might be do-able though.

Fixes #16363

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Nov 23, 2020
@diosmosis diosmosis added this to the 4.1.0 milestone Nov 23, 2020
@sgiehl sgiehl force-pushed the 16363-profilable-disable-features branch from a61abca to 6636838 Compare May 9, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Consistent Reports & Analytics UX For bugs and features that make Analytics reporting UI behave more consistently. c: Data Integrity & Accuracy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide features that don't work when the website is configured in cookie-less tracking
5 participants