Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing invalidations before scheduling new ones #16772

Merged
merged 2 commits into from Nov 23, 2020
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 23, 2020

Description:

@diosmosis is this what you meant regarding Custom Reports?

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the Needs Review PRs that need a code review label Nov 23, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 23, 2020
@tsteur
Copy link
Member Author

tsteur commented Nov 23, 2020

Tested it locally and looked good

@diosmosis
Copy link
Member

@tsteur am adding a test currently

@tsteur
Copy link
Member Author

tsteur commented Nov 23, 2020

@diosmosis just did add one now... committing

@@ -544,12 +544,15 @@ public function removeInvalidations($idSite, $plugin, $report = null)
* since adding invalidations can take a long time and delay UI response times.
*
* @param int|int[]|'all' $idSites
* @param string $pluginName
* @param string|int $pluginName
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowed int since mysqli might return int in some cases. We can convert to string though if needed eg in Funnels etc

@tsteur tsteur merged commit 9da2de3 into 4.x-dev Nov 23, 2020
@tsteur tsteur deleted the corearchivere branch November 23, 2020 01:18
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants