Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disablePerformanceTracking method to methods to apply first #16768

Merged
merged 3 commits into from Nov 22, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 22, 2020

Description:

Otherwise might not be executed in time before track page view etc if not called in correct order. fyi @sgiehl

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 22, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 22, 2020
@tsteur
Copy link
Member Author

tsteur commented Nov 22, 2020

build js

@tsteur
Copy link
Member Author

tsteur commented Nov 22, 2020

fyi @sgiehl @diosmosis will merge this

@tsteur tsteur merged commit 00fc009 into 4.x-dev Nov 22, 2020
@tsteur tsteur deleted the applyperf branch November 22, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant