core:archive add note message when continuing an existing queue #16765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
requested changes
Nov 22, 2020
There was a problem hiding this comment.
getting this error because at this point it seems websiteIdArchiveList is not defined yet?
Uncaught exception: Error: Call to a member function isContinuingPreviousRun() on null in core/CronArchive.php:1005
Stack trace:
#0 core/CronArchive.php(295): Piwik\CronArchive->logArchiveTimeoutInfo()
#1 core/CronArchive.php(266): Piwik\CronArchive->init()
core/CronArchive.php
Outdated
| @@ -1001,6 +1000,11 @@ private function logArchiveTimeoutInfo() | |||
| $this->logger->info("- Archiving was last executed without error " | |||
| . $this->formatter->getPrettyTimeFromSeconds($dateLast, true) . " ago"); | |||
| } | |||
|
|
|||
|
|
|||
| if ($this->websiteIdArchiveList->isContinuingPreviousRun()) { | |||
There was a problem hiding this comment.
@diosmosis not too important since we don't have it for any of the other methods in those classes but might make sense to add an interface to the sharedsiteids and fixedsiteids just to make sure those things are implemented (or could check if the method exists)
|
@tsteur updated |
|
@tsteur fyi, merged this one |
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Noticed core:archive no longer says when it's continuing an existing archive run (if it ever did). Found it confusing for it to just pick up a different queue locally, so thought this message might be useful.
Review