@nina-py opened this Pull Request on November 20th 2020 Contributor

Description:

Turning the multi_server_environment setting on now hides the following
settings from the Administration -> Settings -> General settings page:

  • Archiving settings
  • Email server
  • Trusted Matomo hostname
  • Update settings

...so that users cannot set these separately on different instances of Matomo. Assuming I got these right, are there any other settings that should be disabled when multi_server_environment is turned on?

Fixes #14390.

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on November 22nd 2020 Member

Makes sense @nina-py

Might need to add a note in config/global.ini.php for multi_server_environment that this flag doesn't need to be enabled when the config file is on a shared filesystem like NFS or EFS.

@nina-py commented on November 22nd 2020 Contributor

Thanks @tsteur, added a note to the global config file.

@nina-py commented on November 30th 2020 Contributor

Hi @tsteur , is there anything else that needs to be done in this PR? Or are you guys just way too busy at the moment following the 4.0.x release?

@tsteur commented on November 30th 2020 Member

@nina-py at the moment we're indeed quite busy with the Matomo 4 release. @sgiehl can you do another review maybe?

Powered by GitHub Issue Mirror