Update PHP extension requirements & deprecate Common::mb_* methods #16754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Our System check currently marks some PHP extensions as required that we actually don't need to require.
Those two are meanwhile built in PHP and can't be unavailable, so doesn't make sense to check them at all.
We indirectly already had
symphony/polyfill-mbstring
included in the composer requirements, so the methods are always available. Checking for the extension is therefor not needed anymore, as everything should work without it. (We could also consider adding this as recommended module)I've added
symphony/polyfill-iconv
to ensure those methods are always available. We are actually not using that often, but the mbstring polyfill uses it and it allows us to remove the requirement. (We could also consider adding this as recommended module)In addition I have marked or
Common::mb_*
methods as deprecated and replaced their usage with themb_*
functions directly, as those methods are actually doing nothing else. (We should do that for our plugins later as well)refs #16650
Review