Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On plugin deactivation, invalidations are not fully removed #16749

Closed
tsteur opened this issue Nov 18, 2020 · 0 comments · Fixed by #16753
Closed

On plugin deactivation, invalidations are not fully removed #16749

tsteur opened this issue Nov 18, 2020 · 0 comments · Fixed by #16753
Assignees
@diosmosis
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0-RC

Comments

@tsteur
Copy link
Member

tsteur commented Nov 18, 2020

I was trying the new plugin rearchiving on plugin activate.

The activate worked well but the deactivate left thousands of invalidations in the archive_invalidations table.

Problem is that it is not cleaning up segment invalidations by the looks:

Left entries:

image

This is because it only deletes names like done.MultiChannelConversionAttribution%

image

@diosmosis can you have a look at this?
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Nov 18, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 18, 2020
@diosmosis diosmosis self-assigned this Nov 18, 2020
@diosmosis diosmosis mentioned this issue Nov 19, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging a pull request may close this issue.

fix removal of invalidations for segments matomo-org/matomo
2 participants
@diosmosis @tsteur