Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When no deactivation date found, then rearchive as much as allowed #16748

Merged
merged 1 commit into from Nov 19, 2020
Merged

When no deactivation date found, then rearchive as much as allowed #16748

merged 1 commit into from Nov 19, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 18, 2020

Description:

Otherwise it would only rearchive max 1 day back (assuming archiving ran today or yesterday) when activating the plugin for the first time

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 18, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 18, 2020
@tsteur tsteur mentioned this pull request Nov 18, 2020
Merged
9 tasks
@diosmosis diosmosis merged commit 0d6cd2c into 4.x-dev Nov 19, 2020
@diosmosis diosmosis deleted the reschedulefix branch November 19, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @diosmosis