Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assume hidden keywords to be available by default #16747

Merged
merged 4 commits into from Dec 31, 2020
Merged

Assume hidden keywords to be available by default #16747

merged 4 commits into from Dec 31, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 18, 2020

Description:

fixes #16742

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 18, 2020
@tsteur tsteur added this to the 4.1.0 milestone Nov 18, 2020
@Findus23 Findus23 mentioned this pull request Nov 19, 2020
Closed
@sgiehl sgiehl mentioned this pull request Nov 20, 2020
Closed
@diosmosis
Copy link
Member

Would it be a good idea to add a visit w/ a hiddenkeyword referrer to a system test as well as the unit test used?

@sgiehl sgiehl mentioned this pull request Dec 8, 2020
Closed
@sgiehl sgiehl force-pushed the hiddenkeywords branch 2 times, most recently from 3afa302 to 8bc275d Compare December 18, 2020 12:51
@sgiehl
Copy link
Member Author

sgiehl commented Dec 18, 2020

@diosmosis added simple system test

@mattab mattab modified the milestones: 4.1.0, 4.2.0 Dec 21, 2020
@diosmosis diosmosis merged commit 95db75a into 4.x-dev Dec 31, 2020
@diosmosis diosmosis deleted the hiddenkeywords branch December 31, 2020 02:49
@sgiehl sgiehl mentioned this pull request Jan 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Use hiddenkeyword for Search engines by default
4 participants
@sgiehl @diosmosis @tsteur @mattab