Ignore plugin timings when matomo is not installed yet #16744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
|
@diosmosis do we actually need the last activation time at all? If I see things right we're not using it so could maybe ignore it. Although can also keep it assuming it might be useful for troubleshooting in future |
|
@tsteur I don't think it's currently useful for anything, just seemed like it might be useful in the future. Will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
refs #16741
Not sure if it will fix the issue as I don't know how ExtraTools works. Figured this might still be good to have though maybe just in case to prevent possible install errors. Could maybe even skip saving the timing while Matomo is not installed yet maybe but be good to have them if/when possible. Might be useful for cloud too haven't checked yet (edit: tested and cloud setup still works normal)
Review