@tsteur opened this Pull Request on November 18th 2020 Member

Description:

refs https://github.com/matomo-org/matomo/issues/16741

Not sure if it will fix the issue as I don't know how ExtraTools works. Figured this might still be good to have though maybe just in case to prevent possible install errors. Could maybe even skip saving the timing while Matomo is not installed yet maybe but be good to have them if/when possible. Might be useful for cloud too haven't checked yet (edit: tested and cloud setup still works normal)

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on November 18th 2020 Member

@diosmosis do we actually need the last activation time at all? If I see things right we're not using it so could maybe ignore it. Although can also keep it assuming it might be useful for troubleshooting in future

@diosmosis commented on November 19th 2020 Member

@tsteur I don't think it's currently useful for anything, just seemed like it might be useful in the future. Will merge this.

This Pull Request was closed on November 19th 2020
Powered by GitHub Issue Mirror