Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hiddenkeyword for Search engines by default #16742

Closed
Findus23 opened this issue Nov 18, 2020 · 3 comments · Fixed by #16747
Closed

Use hiddenkeyword for Search engines by default #16742

Findus23 opened this issue Nov 18, 2020 · 3 comments · Fixed by #16747
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. RFC Indicates the issue is a request for comments where the author is looking for feedback.

Comments

@Findus23
Copy link
Member

while this mostly affects https://github.com/matomo-org/searchengine-and-social-list/ I think this should be changed in Matomo itself
reported in https://forum.matomo.org/t/search-engines-in-the-list-of-websites/37192/12?u=lukas

Matomo doesn't detect a lot of search engines anymore as the detection assumes that the referrer URL contains the search query specified in the search engine list. But hardly any search engine sends it anymore, so it doesn't work.

As a workaround it seems like the hiddenkeyword keyword was added to the yaml file to specify the URL that is used to do the redirect over and which will be then the referrer URL.

But as referrer policy and such things are now widespread, no one opens links via redirects anymore and this is again pointless.

One could fix this issue by adding

hiddenkeyword:
  - '/^$/'
  - '/'

to every search engine in the list, but at this point the setting becomes useless and instead I think Matomo should instead handle every referrer URL like https://www.startpage.com/ as a search engine independent on the exact URL or query parameters.

@Findus23 Findus23 added c: Usability For issues that let users achieve a defined goal more effectively or efficiently. RFC Indicates the issue is a request for comments where the author is looking for feedback. labels Nov 18, 2020
@sgiehl
Copy link
Member

sgiehl commented Nov 18, 2020

Guess it would make sense to simply assume the hiddenkeyword values as default if there is non defined by the search engine

@tsteur
Copy link
Member

tsteur commented Nov 18, 2020

sounds like an easy fix? I assume it's unlikely a search engine links to you anyway :)

@sgiehl
Copy link
Member

sgiehl commented Nov 18, 2020

That's very easy. Will create a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. RFC Indicates the issue is a request for comments where the author is looking for feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants