Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check for dangling invalidations #16739

Merged
merged 1 commit into from Nov 18, 2020
Merged

add check for dangling invalidations #16739

merged 1 commit into from Nov 18, 2020

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Nov 18, 2020 •
edited by tsteur

Description:

Temporarily include check for dangling invalidations in case there's some issue w/ core:archive's finishing/removal of invalidations. refs #16689

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 18, 2020
@diosmosis diosmosis added this to the 4.0.0-RC milestone Nov 18, 2020
@tsteur tsteur merged commit e2f4903 into 4.x-dev Nov 18, 2020
@tsteur tsteur deleted the core-archive-double-check branch November 18, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @tsteur