Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New diagnotic warning when both auto archiving and browser archiving are enabled #16738

Merged
merged 2 commits into from Nov 18, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 18, 2020

Description:

as per title

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the Needs Review PRs that need a code review label Nov 18, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 18, 2020
@diosmosis
Copy link
Member

@tsteur I think the new translations are missing

@tsteur
Copy link
Member Author

tsteur commented Nov 18, 2020

added them @diosmosis

@diosmosis diosmosis merged commit 28c39f4 into 4.x-dev Nov 18, 2020
@diosmosis diosmosis deleted the detectbotharchive branch November 18, 2020 05:27
@mattab mattab changed the title Detect when both auto archiving and browser archiving is enabled New diagnotic warning when both auto archiving and browser archiving are enabled Nov 23, 2020
@mattab mattab added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants