Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow uninstalling custom variables and provider for a while #16734

Merged
merged 4 commits into from Nov 18, 2020
Merged

Do not allow uninstalling custom variables and provider for a while #16734

merged 4 commits into from Nov 18, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 17, 2020 •
edited

Description:

fix #16517 as discussed in the issue

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 17, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 17, 2020
@tsteur tsteur added the Needs Review PRs that need a code review label Nov 17, 2020
@tsteur
Copy link
Member Author

tsteur commented Nov 18, 2020

fyi I will be merging this one @sgiehl @diosmosis so we can release eventually yet another RC. Let me know if there's any issue with this one.

@tsteur tsteur merged commit 3a268b1 into 4.x-dev Nov 18, 2020
@tsteur tsteur deleted the m16517 branch November 18, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

Integrity Checker is incorrect for CustomVariables and Provider
1 participant
@tsteur