Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve newly added dimensions/metrics #16731

Merged
merged 2 commits into from Nov 17, 2020
Merged

Improve newly added dimensions/metrics #16731

merged 2 commits into from Nov 17, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 17, 2020

Description:

Due to #16684 some dimensions are not showing up in custom reports and have automatically configured metrics. Some of them are not useful:

  • The Provider column shouldn't have a name, as it should not appear as dimension at all. It's already available through Provider plugin and will/should be moved there in the future.

  • All browser plugin dimensions are currently having automatically configured metrics. But metrics such as Avg. Plugin (Java) Per Visit doesn't make sense. So only configure a useful metric for each plugin.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 17, 2020
@sgiehl sgiehl added this to the 4.0.0-RC milestone Nov 17, 2020
@tsteur
Copy link
Member

tsteur commented Nov 17, 2020

works
image

@tsteur tsteur merged commit 72936e1 into 4.x-dev Nov 17, 2020
@tsteur tsteur deleted the removemetrics branch November 17, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants