Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded metric format in Goal overview #16730

Merged
merged 2 commits into from Nov 17, 2020
Merged

Remove unneeded metric format in Goal overview #16730

merged 2 commits into from Nov 17, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 17, 2020

Description:

fixes #16726

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added this to the 4.1.0 milestone Nov 17, 2020
@sgiehl sgiehl marked this pull request as ready for review November 17, 2020 12:28
@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Nov 17, 2020
@tsteur
Copy link
Member

tsteur commented Nov 17, 2020

Thank you @sgiehl this works for me. Also applied the patch on the org demo (will be overwritten on next update )https://demo.matomo.org/index.php?module=CoreHome&action=index&idSite=62&period=day&date=yesterday#?idSite=62&period=year&date=2020-11-10&segment=&category=Goals_Goals&subcategory=General_Overview

@tsteur tsteur merged commit e9d657a into 4.x-dev Nov 17, 2020
@tsteur tsteur deleted the fixgoalmetricformat branch November 17, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Goal conversions wrongly formatted when using German language
2 participants
@sgiehl @tsteur