Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goal conversions wrongly formatted when using German language #16726

Closed
tsteur opened this issue Nov 16, 2020 · 1 comment · Fixed by #16730
Closed

Goal conversions wrongly formatted when using German language #16726

tsteur opened this issue Nov 16, 2020 · 1 comment · Fixed by #16730
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Nov 16, 2020

See https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=year&date=2020-11-15&segment=&category=Goals_Goals&subcategory=General_Overview when selecting Deutsch (German) in the language selector.

image

You can see eg conversions should be "232469" but it is shown as 232,47 in German which means 232.47 in English. So the shown value is 1000 times lower than expected. This also applies to the other goals on the same page

image

and it applies to the individual goal pages

image

Was wondering if it is maybe related to #15262 but don't think so.

@sgiehl maybe we already have an issue for this? Couldn't find anything. I suppose it's not an easy fix? (just asking in case you remember from previous fixes)

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Nov 16, 2020
@tsteur tsteur added this to the 4.1.0 milestone Nov 16, 2020
@sgiehl
Copy link
Member

sgiehl commented Nov 17, 2020

there are #15356, #15200, #15346 and maybe even a few others. In most cases there was "simply" a number formatting where it was already done. Will have a quick look if it's easy to fix here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants