Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When token is anonymous do not append force api session #16725

Merged
merged 2 commits into from Nov 16, 2020
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 16, 2020

Description:

When viewing the list of API's in Matomo otherwise the example URL looks like https://demo.matomo.cloud/?module=API&method=DevicesDetection.getModel&idSite=1&period=day&date=yesterday&format=JSON&token_auth=anonymous&force_api_session=1

By not appending the force_api_session=1 when token is anonymous users can more easily tweak the token and don't have to manually remove the URL parameter. see eg https://developer.matomo.org/api-reference/reporting-api#CustomAlerts

When the token is anonymous the force_api_session is not needed.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 16, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 16, 2020
@tsteur tsteur merged commit 2fcd5e5 into 4.x-dev Nov 16, 2020
@tsteur tsteur deleted the docsgenerator branch November 16, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants