@fealXX opened this Pull Request on November 16th 2020

Description:

Re-implements the Changes made by @beger in PR#16504, added the discussed functionality

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on November 17th 2020 Member

Worked for me. Wasn't sure if it affects eg deleteCookie but all seems to work and seems safe to merge for 4.0 release.

We will next need to merge this into a different branch in our repo, build the minified JS and add a simple test to API methods that the method exists and update the documentation. Hoping to do this tomorrow.

This Pull Request was closed on November 17th 2020
Powered by GitHub Issue Mirror