Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it clear that tracking ISP data requires Provider plugin #16718

Merged
merged 1 commit into from Nov 15, 2020
Merged

Make it clear that tracking ISP data requires Provider plugin #16718

merged 1 commit into from Nov 15, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 15, 2020

Description:

refs #16712

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 15, 2020
@sgiehl sgiehl added this to the 4.0.0-RC milestone Nov 15, 2020
@tsteur tsteur merged commit b141842 into 4.x-dev Nov 15, 2020
@tsteur tsteur deleted the ispdb branch November 15, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur