New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo in deleting blob archive data #16717
Conversation
LGTM @diosmosis I suppose you add the DB upgrade statement here? |
@tsteur added the new update |
core/Updates/4.0.0-rc4.php
Outdated
{ | ||
$migrations = []; | ||
|
||
$dates = ['2020-01-01', '2020-10-01', '2020-09-01']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diosmosis does it need november in there too? I reckon we could actually remove September but no preference. We only released the beta on like 29th of September so it wouldn't have been much of an issue back then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes, it should, will fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsteur updated
core/Updates/4.0.0-rc4.php
Outdated
$blobTable = ArchiveTableCreator::getNumericTable($date); | ||
|
||
$migrations[] = $this->migration->db->sql("DELETE FROM `$blobTable` WHERE idarchive NOT IN ( | ||
SELECT idarchive FROM `$numericTable`)"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably won't make a difference but might be better to use SELECT DISTINCT
in the subquery? I reckon this might speed up the deletion since it will need to check a lot less entries for each row whether id is included
Description:
archive tables are determined by start date, but we're using end date in this one place (probably due to autocomplete error)
Review