Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ecommerce and goal tracking may not work #16716

Merged
merged 2 commits into from Nov 15, 2020
Merged

Fix ecommerce and goal tracking may not work #16716

merged 2 commits into from Nov 15, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 15, 2020

Description:

Seems they rely on page view action in order to work and should therefore not send the ca parameter

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 15, 2020
@tsteur
Copy link
Member Author

tsteur commented Nov 15, 2020

build js

@tsteur tsteur merged commit eed9424 into 4.x-dev Nov 15, 2020
@tsteur tsteur deleted the jsecommerceerror branch November 15, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tsteur