@nina-py opened this Pull Request on November 13th 2020 Contributor

Description:

Added a method called by the updater task that updates the DB-IP URL if needed to the latest downloaded one instead of the one set in the options when Matomo was initially installed. This removes much of the confusion at seeing a seemingly outdated URL being used on the GeoIP2 plugin page.

Would love to contribute a test as well but need to make sure I add the right test in the right place - I think a system test would be the right one for this method as I'd need to make sure an option was changed?

Tested the changes by manually setting the geoip2.loc_db_url option to https://download.db-ip.com/free/dbip-city-lite-2020-05.mmdb.gz in the database, then running the updater task with

./console core:run-scheduled-tasks "Piwik\Plugins\GeoIp2\GeoIP2AutoUpdater.update"

Result - option set to https://download.db-ip.com/free/dbip-city-lite-2020-11.mmdb.gz and the plugin page now displays the latest URL in the "Download URL" field.

Fixes #16618.

Review

  • [x] Functional review done
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done see checklist
  • [x] Code review done
  • [ ] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [x] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
@sgiehl commented on November 17th 2020 Member

@tsteur Guess should be fine to merge that for 4.0 already. Feel free to do that or to move it to another milestone.

@tsteur commented on November 17th 2020 Member

Thanks @nina-py very appreciated

This Pull Request was closed on November 17th 2020
Powered by GitHub Issue Mirror