Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that tracking ISP data requires Provider plugin #16712

Closed
sgiehl opened this issue Nov 13, 2020 · 4 comments · Fixed by #16756
Closed

Clarify that tracking ISP data requires Provider plugin #16712

sgiehl opened this issue Nov 13, 2020 · 4 comments · Fixed by #16756
Assignees
@sgiehl
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.1.0

Comments

@sgiehl
Copy link
Member

sgiehl commented Nov 13, 2020

As of Matomo 4 the Provider plugin is no longer part of core. Even though we still ship it together, the plugin is deactivated by default.

In the Geolocation admin it is always possible to configure an ISP database. But actually the ISP/ORG information gathered through that database will only be stored if the Provider plugin has been installed (e.g. the location_provider column exists) and won't be shown unless it is activated.

We should disable that field if the plugin isn't activated and add a note that the Provider plugin is required in order to use an ISP database.

Also we might need to check if it doesn't make any further problems that a dimension in core exists that requires a column that is installed by a plugin. Maybe it would be better to move those parts to the Provider plugin
@sgiehl sgiehl added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Nov 13, 2020
@tsteur tsteur added this to the 5.0.0 milestone Nov 15, 2020
@tsteur
Copy link
Member

tsteur commented Nov 15, 2020

@sgiehl I'll disable the dimension through custom reports. I'm thinking maybe we could move the dimension to the plugin in Matomo 5 and during transition period keep it in Matomo 4 so no schema changes will happen or so should the plugin be activated etc.

For the admin could we create a separate issue or could you create a PR to mention it requires the Provider plugin to be enabled should it not be enabled?

@sgiehl
Copy link
Member Author

sgiehl commented Nov 15, 2020

For the admin could we create a separate issue or could you create a PR to mention it requires the Provider plugin to be enabled should it not be enabled?

Will create a PR

@sgiehl
Copy link
Member Author

sgiehl commented Nov 15, 2020 •
edited

Btw. @tsteur . Moving that dimension should not trigger a database change, as the definition is already in the provider plugin. So it should be possible to do that anytime.

@sgiehl sgiehl mentioned this issue Nov 15, 2020
Merged
9 tasks
@tsteur
Copy link
Member

tsteur commented Nov 15, 2020

Good one @sgiehl didn't notice. If it's not used in any other way then feel free to move that logic to the provider plugin. Moving this to Matomo 4.1

@tsteur tsteur modified the milestones: 5.0.0, 4.1.0 Nov 15, 2020
@sgiehl sgiehl self-assigned this Nov 19, 2020
This was referenced Nov 19, 2020
Merged
Merged
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

Remove provider lookup from core matomo-org/matomo
3 participants
@tsteur @mattab @sgiehl