Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround shell_exec being disabled #16710

Merged
merged 1 commit into from Nov 15, 2020
Merged

Workaround shell_exec being disabled #16710

merged 1 commit into from Nov 15, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 13, 2020

Description:

Prevent error like this:

Backtrace from warning 'shell_exec() has been disabled for security reasons' at /wp-content/plugins/matomo/app/core/CliMulti/CliPhp.php 43:

in WordPress System Report. There are probably few other shell_exec usages but probably not needed to adjust these for now.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 13, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 13, 2020
@tsteur tsteur merged commit 0a0b4ba into 4.x-dev Nov 15, 2020
@tsteur tsteur deleted the shellexec branch November 15, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl