Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport confirm password fix for loginldap on 3.x #16709

Merged
merged 2 commits into from Nov 16, 2020
Merged

backport confirm password fix for loginldap on 3.x #16709

merged 2 commits into from Nov 16, 2020

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Nov 13, 2020 •
edited

Description:

Use activated login plugin method in confirm password workflow, not Login since it will be deactivated when another login plugin exists.

Todo

  • after merge and release, release new LoginLdap 3.x series

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Nov 13, 2020
@diosmosis diosmosis added this to the 3.14.2 milestone Nov 13, 2020
@sgiehl
Copy link
Member

sgiehl commented Nov 13, 2020

@diosmosis did you update the TagManager submodule on purpose?

@diosmosis
Copy link
Member Author

@sgiehl no, not on purpose, will remove

@tsteur
Copy link
Member

tsteur commented Nov 15, 2020

seems it doesn't break any test so we can merge this @diosmosis @sgiehl ?

@diosmosis
Copy link
Member Author

will merge, if there's an issue let me know and i'll fix in another pr

@diosmosis diosmosis merged commit 18fe800 into 3.x-dev Nov 16, 2020
@diosmosis diosmosis deleted the confirm-pwd-3.x branch November 16, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @tsteur