@diosmosis opened this Pull Request on November 13th 2020 Member

Description:

Use activated login plugin method in confirm password workflow, not Login since it will be deactivated when another login plugin exists.

Todo

  • [ ] after merge and release, release new LoginLdap 3.x series

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on November 13th 2020 Member

@diosmosis did you update the TagManager submodule on purpose?

@diosmosis commented on November 14th 2020 Member

@sgiehl no, not on purpose, will remove

@tsteur commented on November 15th 2020 Member

seems it doesn't break any test so we can merge this @diosmosis @sgiehl ?

@diosmosis commented on November 16th 2020 Member

will merge, if there's an issue let me know and i'll fix in another pr

This Pull Request was closed on November 16th 2020
Powered by GitHub Issue Mirror