fix parameter order in quickform #16708

Findus23 · 2020-11-12T20:27:25Z

Just saw the deprecation warning when testing PHP 8

PHP Deprecated: Required parameter $filter follows optional parameter $key in /var/www/matomo/libs/HTML/QuickForm2/Node.php on line 681

It is only called in those two lines:

matomo/libs/HTML/QuickForm2/Node.php

Lines 670 to 676 in 0d66104

    
           foreach ($this->filters as $filter) { 
        
               if (is_array($value) && !empty($filter['recursive'])) { 
        
                   array_walk_recursive($value,  
        
                       array('HTML_QuickForm2_Node', 'applyFilter'), $filter); 
        
               } else { 
        
                   self::applyFilter($value, null, $filter); 
        
               }

The second one is safe, I am not too sure about the first one.

Review

Functional review done
Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
Security review done see checklist
Code review done
Tests were added if useful/possible
Reviewed for breaking changes
Developer changelog updated if needed
Documentation added if needed
Existing documentation updated if needed

fix parameter order in quickform

0d66104

tsteur merged commit 7386326 into 4.x-dev Nov 12, 2020

tsteur deleted the quickform-paramter-order branch November 12, 2020 20:51

mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix parameter order in quickform #16708

fix parameter order in quickform #16708

Findus23 commented Nov 12, 2020

	foreach ($this->filters as $filter) {
	if (is_array($value) && !empty($filter['recursive'])) {
	array_walk_recursive($value,
	array('HTML_QuickForm2_Node', 'applyFilter'), $filter);
	} else {
	self::applyFilter($value, null, $filter);
	}

fix parameter order in quickform #16708

fix parameter order in quickform #16708

Conversation

Findus23 commented Nov 12, 2020

Review