@sgiehl opened this Pull Request on November 12th 2020 Member

Description:

Getting plugin de/activation time might throw an exception if option value is returned as string instead of integer.
Came across that while testing #16702 with one of the plugin PRs. Might be depending on the database configuration, as the tests pass locally. But when using the methods in a plugin the option value is returned as a string resulting in an exception: Date format must be: YYYY-MM-DD, or 'today' or 'yesterday' or any keyword supported by the strtotime function (see http://php.net/strtotime for more information)

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on November 12th 2020
Powered by GitHub Issue Mirror