Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix methods to get plugin de-/activation time. #16705

Merged
merged 1 commit into from Nov 12, 2020
Merged

Fix methods to get plugin de-/activation time. #16705

merged 1 commit into from Nov 12, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 12, 2020

Description:

Getting plugin de/activation time might throw an exception if option value is returned as string instead of integer.
Came across that while testing #16702 with one of the plugin PRs. Might be depending on the database configuration, as the tests pass locally. But when using the methods in a plugin the option value is returned as a string resulting in an exception: Date format must be: YYYY-MM-DD, or 'today' or 'yesterday' or any keyword supported by the strtotime function (see http://php.net/strtotime for more information)

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

Getting plugin de/activation time might throw an exception if option value is returned as string instead of integer
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 12, 2020
@sgiehl sgiehl added this to the 4.0.0-RC milestone Nov 12, 2020
@sgiehl sgiehl mentioned this pull request Nov 12, 2020
9 tasks
@tsteur tsteur merged commit ba6a45e into 4.x-dev Nov 12, 2020
@tsteur tsteur deleted the plugintimes branch November 12, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants