@diosmosis opened this Pull Request on November 11th 2020 Member

Description:

Refs #16396

Schedule rearchiving calls in a list and apply later in core:archive. CC @tsteur

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on November 11th 2020 Member

ideally we also adjust removeInvalidationsSafely to additionally remove any entry from the list that matches the given pluginName (and maybe idsites)?

👍

@diosmosis commented on November 12th 2020 Member

@tsteur Applied pr fixes.

@tsteur commented on November 12th 2020 Member

I'll be mostly in meetings tmrw. @sgiehl could you test this tomorrow? and then we adjust the plugins that use this in activate/deactivate plugin

@sgiehl commented on November 12th 2020 Member

tested that locally with adjusted Cohorts PR. Besides the comments I've added and #16705 it seems to work as expected.

@tsteur commented on November 13th 2020 Member

👍 @diosmosis so seems good to merge once tests pass?

@sgiehl commented on November 13th 2020 Member

Guess you missed that comment: https://github.com/matomo-org/matomo/pull/16702#discussion_r522023501
Will create a PR to fix that

@diosmosis commented on November 14th 2020 Member

Guess you missed that comment: #16702 (comment)

yes, missed it, the tab that had this github page didn't update I guess

This Pull Request was closed on November 13th 2020
Powered by GitHub Issue Mirror