Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash equals method #16696

Merged
merged 2 commits into from Nov 10, 2020
Merged

Add hash equals method #16696

merged 2 commits into from Nov 10, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 10, 2020

Description:

A new method Common::hashEquals has been added for timing attack safe string comparisons

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added this to the 4.0.0-RC milestone Nov 10, 2020
@tsteur tsteur added the Needs Review PRs that need a code review label Nov 10, 2020
@tsteur
Copy link
Member Author

tsteur commented Nov 10, 2020

fyi @sgiehl @diosmosis merging this one already so it's included in next RC and can be used as I already added the docs.

@tsteur tsteur merged commit b984ce6 into 4.x-dev Nov 10, 2020
@tsteur tsteur deleted the hashequals branch November 10, 2020 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant