Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use "Matomo" in user agent used for outgoing HTTP requests #16692

Merged
merged 2 commits into from Nov 10, 2020
Merged

use "Matomo" in user agent used for outgoing HTTP requests #16692

merged 2 commits into from Nov 10, 2020

Conversation

Findus23
Copy link
Member

quite minor, but Matomo 4 would be a good time to update the user agent (used for outgoing HTTP requests)

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added the Needs Review PRs that need a code review label Nov 10, 2020
@Findus23 Findus23 added this to the 4.0.0-RC milestone Nov 10, 2020
@tsteur
Copy link
Member

tsteur commented Nov 10, 2020

Thanks @Findus23

@tsteur tsteur merged commit 9e1bf2d into 4.x-dev Nov 10, 2020
@tsteur tsteur deleted the matomo-user-agent branch November 10, 2020 20:46
@mattab mattab changed the title use Matomo in user agent use "Matomo" in user agent used for outgoing HTTP requests Nov 10, 2020
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Findus23 @tsteur @mattab