Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show invalidation information in system check #16690

Merged
merged 4 commits into from Nov 10, 2020
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 10, 2020

Description:

refs #16689 adds information about archive invalidation entries to the informational system check output so we don't need to ask users to run queries. Can help understand archiving issues.
fyi @diosmosis maybe something else be useful too?

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added the Needs Review PRs that need a code review label Nov 10, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 10, 2020
@tsteur
Copy link
Member Author

tsteur commented Nov 10, 2020

fyi I'll merge this for the next RC @diosmosis let me know in case you have any further thoughts on this

@tsteur tsteur merged commit 9dbf0f3 into 4.x-dev Nov 10, 2020
@tsteur tsteur deleted the invalidationinfo branch November 10, 2020 21:13
@diosmosis
Copy link
Member

Maybe checking the oldest invalidation date might be useful. Otherwise the core:archive logs are probably more useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants