Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new parameters for campaign group and placement to campaign builder #16688

Merged
merged 2 commits into from Nov 10, 2020
Merged

Adds new parameters for campaign group and placement to campaign builder #16688

merged 2 commits into from Nov 10, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 10, 2020 •
edited by tsteur

Description:

fixes #16682

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 10, 2020
@sgiehl sgiehl added this to the 4.0.0-RC milestone Nov 10, 2020
@tsteur
Copy link
Member

tsteur commented Nov 10, 2020

Works nicely 👍

@tsteur tsteur merged commit 534c896 into 4.x-dev Nov 10, 2020
@tsteur tsteur deleted the campaignbuilder branch November 10, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

Update campaign builder with new parameters group and placement
2 participants
@sgiehl @tsteur