Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added whitespace to the bottom of email template #16687

Merged
merged 1 commit into from Nov 10, 2020
Merged

Added whitespace to the bottom of email template #16687

merged 1 commit into from Nov 10, 2020

Conversation

nina-py
Copy link
Contributor

@nina-py nina-py commented Nov 9, 2020

Description:

The issue was that the div element that wrapped the contents of the email had both top and bottom margins set to zero. There is spacing between the email text and the (dark blue) header thanks to the 25px bottom margin on the header. Added a matching 25px bottom margin on the wrapper div.

Fixes #13953.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@nina-py
Added whitespace to the bottom of email template
d16a17b 
The issue was that the div element that wrapped the contents of the email
had both top and bottom margins set to zero. There is spacing between
the email text and the (dark blue) header thanks to the 25px bottom margin
on the header. Added a matching 25px bottom margin on the wrapper div.

Fixes #13953.
@tsteur tsteur added the Needs Review PRs that need a code review label Nov 9, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 9, 2020
@tsteur
Copy link
Member

tsteur commented Nov 10, 2020

Thanks @nina-py that worked for me. 👍

@tsteur tsteur merged commit 9676053 into matomo-org:4.x-dev Nov 10, 2020
@nina-py nina-py deleted the 13953-add-whitespace-to-password-reset-email-footer branch November 10, 2020 23:14
@nina-py
Copy link
Contributor Author

nina-py commented Nov 10, 2020

Great to hear that @tsteur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

Auto generated Password Reset email is missing white space in the footer
2 participants
@nina-py @tsteur