Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set name and default value for certain dimensions. #16684

Merged
merged 3 commits into from Nov 10, 2020
Merged

Set name and default value for certain dimensions. #16684

merged 3 commits into from Nov 10, 2020

Conversation

diosmosis
Copy link
Member

Description:

As title. FYI @tsteur

Refs #16609

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 9, 2020
@diosmosis diosmosis added this to the 4.0.0-RC milestone Nov 9, 2020
@tsteur
Copy link
Member

tsteur commented Nov 9, 2020

LGTM if tests @diosmosis

@tsteur tsteur merged commit 3c64683 into 4.x-dev Nov 10, 2020
@tsteur tsteur deleted the couple-dimension-improvements branch November 10, 2020 19:27
@sgiehl sgiehl mentioned this pull request Nov 17, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @tsteur