Fix spelling of "Pie chart" #16680
Merged
Fix spelling of "Pie chart" #16680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pie chart should be two words instead of one.
|
Hi, This should work. Just keep in mind that this invalidates all translations meaning it should not be merged shortly before a release when translators don't have time to catch up. |
|
I'll merge that now and will update the invalidated translations on transifex manually. As the translation would actually all still be valid it imho doesn't make sense to wait until they get translated again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pie chart should be two words instead of one.
Description:
@mattab advised to open issue re pie chart wording.
Review
None. This looks like it should work, but not sure how you specifically manage string translation.