Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download GeoIP files always to tmp directory #16677

Merged
merged 1 commit into from Nov 9, 2020
Merged

Download GeoIP files always to tmp directory #16677

merged 1 commit into from Nov 9, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 6, 2020

Description:

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

tsteur
tsteur approved these changes Nov 8, 2020
View reviewed changes
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test it but LGTM @sgiehl

@sgiehl sgiehl added this to the 4.0.0-RC milestone Nov 9, 2020
@sgiehl
Copy link
Member Author

sgiehl commented Nov 9, 2020

Tested both use cases locally and everything still worked

@sgiehl sgiehl merged commit 3d8f8ca into 4.x-dev Nov 9, 2020
@sgiehl sgiehl deleted the downloadtmp branch November 9, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur