Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix siteSearchCategory segment #16675

Merged
merged 5 commits into from Nov 9, 2020
Merged

Fix siteSearchCategory segment #16675

merged 5 commits into from Nov 9, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 6, 2020 •
edited by diosmosis

Description:

fixes #16674

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added this to the 4.0.0-RC milestone Nov 6, 2020
@sgiehl sgiehl marked this pull request as ready for review November 6, 2020 08:48
@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Nov 6, 2020
@sgiehl
Copy link
Member Author

sgiehl commented Nov 6, 2020

failing UI tests are unrelated

@diosmosis
Copy link
Member

Not sure if this is related to the original bug, but something I noticed:

the search category report doesn't have segmented visitor log icon:

image

@sgiehl
Copy link
Member Author

sgiehl commented Nov 8, 2020

Might be useful to add that as well... Will do that

@sgiehl
Copy link
Member Author

sgiehl commented Nov 8, 2020

@diosmosis updated the PR

@diosmosis diosmosis merged commit 38753e4 into 4.x-dev Nov 9, 2020
@diosmosis diosmosis deleted the fixsegment branch November 9, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

SearchCategory segment issue?
2 participants
@sgiehl @diosmosis