Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchCategory segment issue? #16674

Closed
tsteur opened this issue Nov 6, 2020 · 0 comments · Fixed by #16675
Closed

SearchCategory segment issue? #16674

tsteur opened this issue Nov 6, 2020 · 0 comments · Fixed by #16675
Assignees
@sgiehl
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
4.0.0-RC

Comments

@tsteur
Copy link
Member

tsteur commented Nov 6, 2020

see https://github.com/matomo-org/matomo/blob/4.0.0-rc1/plugins/Actions/Columns/SearchCategory.php#L36-L41

it's calling a method that no longer exists. Not sure if this is an issue?
image

I'm currently going through all changes in the changelog and checking if all code was adjusted to notice possible bugs and not sure if this one is an issue. I suppose it used to configure a segment maybe but is not anymore? Or maybe it is dead code?
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 6, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 6, 2020
@sgiehl sgiehl self-assigned this Nov 6, 2020
@sgiehl sgiehl mentioned this issue Nov 6, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging a pull request may close this issue.

Fix siteSearchCategory segment matomo-org/matomo
2 participants
@tsteur @sgiehl