@sgiehl opened this Pull Request on November 5th 2020 Member

Description:

This PR creates a new page "Performance" as subcategory of Behaviour.
It contains the performance overview (moved from visitor overview) and the two reports "Pages" and "Page Titles". Both reports have links to the Entry and Exit page reports as related reports.

Note: Exit and Entry page title reports didn't have page performance numbers before, even though they were already calculated. So I've activated them for those reports.

fixes #16669

Review

  • [ ] Functional review done
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on November 5th 2020 Member

@sgiehl could you move Performance further up say after Transitions?
image

I think the side by side reports don't work so well since there are so many columns

image

could we show the reports below each other? There should be some flag somewhere like wide.... Don't remember the name right now.

Only did a quick functional check.

@sgiehl commented on November 6th 2020 Member

@tsteur Updated the PR accordingly.

Note: UI screenshots in some submodules needs to be updated before merging.

@sgiehl commented on November 8th 2020 Member

@tsteur I can have a look if that would be easy doable. Should the row action be still in the normal action reports or only on the performance reports. Also that would apply for the dashboard widgets, so we would need to make the performance page widgets available as well (as those reports would otherwise not be accesible on the dashboard) or allow switching to the page performance viz in the widgets only.
Also keep in mind that the performance viz is also available on the "pages (titles) following site search" reports. Not sure if we should move them to the related reports then as well...

@tsteur commented on November 8th 2020 Member

I reckon row action could be actually useful in all the pages reports, not just in the performance reports.

I reckon we don't need to have "pages (titles) following site search" as a related report for now.

@sgiehl commented on November 9th 2020 Member

@tsteur Ok. So the performance viz is now only hidden on the page reports pages. The page report widgets will still have the possibility to switch to this viz. Let me know if it's fine that way. Will update the expected ui files in the submodules then and merge the PR...

@tsteur commented on November 9th 2020 Member

Sounds good @sgiehl feel free to merge once the tests pass

This Pull Request was closed on November 10th 2020
Powered by GitHub Issue Mirror