Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print error message when activating a plugin #16664

Closed
wants to merge 1 commit into from
Closed

Print error message when activating a plugin #16664

wants to merge 1 commit into from

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 4, 2020

I know the error message should be printed anyway when the exception is triggered but we can't easily get the error on the cloud.

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur
Print error message when activating a plugin
3443e50 
I know the error message should be printed anyway when the exception is triggered but we can't easily get the error on the cloud.
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Nov 4, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 4, 2020
@tsteur tsteur closed this Nov 4, 2020
@tsteur tsteur deleted the activatepluginprinterror branch November 4, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0-RC
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tsteur