Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin might not be loaded when installing the plugin #16663

Merged
merged 5 commits into from Nov 4, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Nov 4, 2020

Noticed this on cloud when testing Matomo 4. When installing the plugin, then it may not be loaded yet.

Could not activate plugin MarketingCampaignsReporting. Message: The plugin 'MarketingCampaignsReporting' has not been loaded. Trace #0 /src/core/AssetManager.php(367): Piwik\Plugin\Manager->getLoadedPlugin('MarketingCampai...')
#1 /src/core/AssetManager.php(242): Piwik\AssetManager->pluginContainsJScriptAssets('MarketingCampai...')
#2 /src/core/Filesystem.php(29): Piwik\AssetManager->removeMergedAssets('MarketingCampai...')
#3 /src/core/Plugin/Manager.php(629): Piwik\Filesystem::deleteAllCacheOnUpdate('MarketingCampai...')
#4 /src/core/Plugin/Manager.php(690): Piwik\Plugin\Manager->clearCache('MarketingCampai...')
#5 /src/plugins/CorePluginsAdmin/Commands/ActivatePlugin.php(48): Piwik\Plugin\Manager->activatePlugin('MarketingCampai...')
#6 /src/vendor/symfony/console/Symfony/Component/Console/Command/Command.php(257): Piwik\Plugins\CorePluginsAdmin\Commands\ActivatePlugin->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 /src/vendor/symfony/console/Symfony/Component/Console/Application.php(874): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

above also happens when eg installing plugin

Review

  • Functional review done
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

>  Could not activate plugin MarketingCampaignsReporting. Message: The plugin 'MarketingCampaignsReporting' has not been loaded. Trace #0 /src/core/AssetManager.php(367): Piwik\Plugin\Manager->getLoadedPlugin('MarketingCampai...')
#1 /src/core/AssetManager.php(242): Piwik\AssetManager->pluginContainsJScriptAssets('MarketingCampai...')
#2 /src/core/Filesystem.php(29): Piwik\AssetManager->removeMergedAssets('MarketingCampai...')
#3 /src/core/Plugin/Manager.php(629): Piwik\Filesystem::deleteAllCacheOnUpdate('MarketingCampai...')
#4 /src/core/Plugin/Manager.php(690): Piwik\Plugin\Manager->clearCache('MarketingCampai...')
#5 /src/plugins/CorePluginsAdmin/Commands/ActivatePlugin.php(48): Piwik\Plugin\Manager->activatePlugin('MarketingCampai...')
#6 /src/vendor/symfony/console/Symfony/Component/Console/Command/Command.php(257): Piwik\Plugins\CorePluginsAdmin\Commands\ActivatePlugin->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 /src/vendor/symfony/console/Symfony/Component/Console/Application.php(874): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 4, 2020
@tsteur tsteur added this to the 4.0.0-RC milestone Nov 4, 2020
@sgiehl
Copy link
Member

sgiehl commented Nov 4, 2020

@tsteur seems there is a test failing due to this changes

@tsteur tsteur merged commit afc8bb1 into 4.x-dev Nov 4, 2020
@tsteur tsteur deleted the pluginnotdefined branch November 4, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants