@tsteur opened this Pull Request on November 4th 2020 Member

Noticed this on cloud when testing Matomo 4. When installing the plugin, then it may not be loaded yet.

Could not activate plugin MarketingCampaignsReporting. Message: The plugin 'MarketingCampaignsReporting' has not been loaded. Trace #0 /src/core/AssetManager.php(367): Piwik\Plugin\Manager->getLoadedPlugin('MarketingCampai...')
#1 /src/core/AssetManager.php(242): Piwik\AssetManager->pluginContainsJScriptAssets('MarketingCampai...')
#2 /src/core/Filesystem.php(29): Piwik\AssetManager->removeMergedAssets('MarketingCampai...')
#3 /src/core/Plugin/Manager.php(629): Piwik\Filesystem::deleteAllCacheOnUpdate('MarketingCampai...')
#4 /src/core/Plugin/Manager.php(690): Piwik\Plugin\Manager->clearCache('MarketingCampai...')
#5 /src/plugins/CorePluginsAdmin/Commands/ActivatePlugin.php(48): Piwik\Plugin\Manager->activatePlugin('MarketingCampai...')
#6 /src/vendor/symfony/console/Symfony/Component/Console/Command/Command.php(257): Piwik\Plugins\CorePluginsAdmin\Commands\ActivatePlugin->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#7 /src/vendor/symfony/console/Symfony/Component/Console/Application.php(874): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

above also happens when eg installing plugin

Review

  • [x] Functional review done
  • [x] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [x] Security review done
  • [x] Code review done
  • [x] Tests were added if useful/possible
  • [x] Reviewed for breaking changes
  • [x] Developer changelog updated if needed
  • [x] Documentation added if needed
  • [x] Existing documentation updated if needed
@sgiehl commented on November 4th 2020 Member

@tsteur seems there is a test failing due to this changes

This Pull Request was closed on November 4th 2020
Powered by GitHub Issue Mirror