add href in link in update message email #16661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
requested changes
Nov 4, 2020
There was a problem hiding this comment.
@aloxe Thanks for creating the PR. Seems you actually only changed a test file. So that wouldn't have any effect. To adjust the mails you need to update this file: https://github.com/matomo-org/matomo/blob/4.x-dev/plugins/Marketplace/templates/_updateCommunicationEmail.twig
|
Hope this is good now. |
tsteur
reviewed
Nov 12, 2020
| @@ -10,14 +10,14 @@ | |||
| {% if hasThemeUpdate %} | |||
| <p> | |||
| {{ 'CoreUpdater_NotificationClickToUpdateThemes'|translate }}<br/> | |||
| {{ host }}index.php?module=CorePluginsAdmin&action=themes | |||
| <a href="{{ host }}index.php?module=CorePluginsAdmin&action=themes">{{ host }}index.php?module=CorePluginsAdmin&action=themes</a> | |||
There was a problem hiding this comment.
@aloxe we probably need to escape the first {{ host }} like this: {{ host|e('html_attr') }}. Also in the link below for better security.
There was a problem hiding this comment.
sorry for the delay, I haven't noticed this comment. I pushed the change just now.
tsteur
approved these changes
Nov 25, 2020
|
Thanks for the contribution, @aloxe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The link in update email is not clickable. This makes it clickable
Review